test_config_validation.py

Go to the documentation of this file.

#!/usr/bin/env python3
# -*- coding: utf-8 -*-
# tests/tests_linter/test_config_validation.py
 
"""
Purpose
-------
Validate the ``.octrc.json`` schema validator and strict-mode enforcement (OI-411).
 
Responsibilities
----------------
- Confirm that ``_validate_octrc_schema()`` accepts well-formed configs.
- Confirm that it rejects unknown profile names, wrong types, and
  non-boolean rule values.
- Confirm tolerance for unknown top-level keys.
 
Diagnostics
-----------
Domain: LINTER-TESTS
L2: test lifecycle
L3: assertion details
L4: deep tracing
 
Contracts
---------
Inputs:  dict configs
Outputs: list[str] validation errors
"""
 
from oct.linter import oct_lint
 
 
def test_empty_config_accepted():
    """An empty dict is valid — nothing to validate."""
    errors = oct_lint._validate_octrc_schema({})
    assert errors == []
 
 
def test_missing_linter_section_accepted():
    """Configs without a linter section are valid."""
    errors = oct_lint._validate_octrc_schema({"other": "value"})
    assert errors == []
 
 
def test_linter_not_object_rejected():
    errors = oct_lint._validate_octrc_schema({"linter": "bogus"})
    assert errors
    assert "'linter' must be an object" in errors[0]
 
 
def test_valid_profile_accepted():
    errors = oct_lint._validate_octrc_schema({"linter": {"profile": "strict"}})
    assert errors == []
 
 
def test_unknown_profile_rejected():
    errors = oct_lint._validate_octrc_schema({"linter": {"profile": "bogus"}})
    assert any("unknown value 'bogus'" in e for e in errors)
 
 
def test_profile_wrong_type_rejected():
    errors = oct_lint._validate_octrc_schema({"linter": {"profile": 123}})
    assert any("'linter.profile' must be a string" in e for e in errors)
 
 
def test_exclude_dirs_add_wrong_type_rejected():
    errors = oct_lint._validate_octrc_schema(
        {"linter": {"exclude_dirs_add": "not_a_list"}}
    )
    assert any("'linter.exclude_dirs_add' must be a list" in e for e in errors)
 
 
def test_exclude_dirs_add_non_string_element_rejected():
    errors = oct_lint._validate_octrc_schema(
        {"linter": {"exclude_dirs_add": ["ok", 42]}}
    )
    assert any("'linter.exclude_dirs_add[1]'" in e for e in errors)
 
 
def test_rules_not_dict_rejected():
    errors = oct_lint._validate_octrc_schema({"linter": {"rules": ["header"]}})
    assert any("'linter.rules' must be an object" in e for e in errors)
 
 
def test_rule_value_not_bool_rejected():
    errors = oct_lint._validate_octrc_schema(
        {"linter": {"rules": {"header": "yes"}}}
    )
    assert any("'linter.rules.header' must be a bool" in e for e in errors)
 
 
def test_complete_valid_config_accepted():
    cfg = {
        "linter": {
            "profile": "compact",
            "exclude_dirs_add": ["vendor", "third_party"],
            "exclude_dirs_remove": ["tests"],
            "wildcard_exclude_add": ["*_generated"],
            "rules": {"type_hints": False, "header": True},
        }
    }
    assert oct_lint._validate_octrc_schema(cfg) == []
 
 
def test_strict_config_requested_default(monkeypatch):
    monkeypatch.delenv("OCT_STRICT_CONFIG", raising=False)
    assert not oct_lint._strict_config_requested()
 
 
def test_strict_config_requested_env(monkeypatch):
    monkeypatch.setenv("OCT_STRICT_CONFIG", "1")
    assert oct_lint._strict_config_requested()
    monkeypatch.setenv("OCT_STRICT_CONFIG", "true")
    assert oct_lint._strict_config_requested()
    monkeypatch.setenv("OCT_STRICT_CONFIG", "0")
    assert not oct_lint._strict_config_requested()
 
 
# =====================================================================
# Phase 4E — G-E8: Git section validation
# =====================================================================
 
 
def test_git_valid_config_accepted():
    """Well-formed git section passes validation."""
    cfg = {
        "git": {
            "protected_branches": ["main", "master"],
            "branch_naming": {"enabled": True, "patterns": [r"^main$"]},
            "pre_commit_profile": "auto",
            "conventional_commits": True,
            "require_changelog_update": False,
            "large_file_warn_mb": 10,
            "timeout": 30,
            "long_timeout": 120,
        }
    }
    assert oct_lint._validate_octrc_schema(cfg) == []
 
 
def test_git_not_object_rejected():
    errors = oct_lint._validate_octrc_schema({"git": "bogus"})
    assert any("'git' must be an object" in e for e in errors)
 
 
def test_git_protected_branches_not_list_rejected():
    errors = oct_lint._validate_octrc_schema(
        {"git": {"protected_branches": "main"}}
    )
    assert any("'git.protected_branches' must be a list" in e for e in errors)
 
 
def test_git_branch_naming_enabled_not_bool_rejected():
    errors = oct_lint._validate_octrc_schema(
        {"git": {"branch_naming": {"enabled": "yes"}}}
    )
    assert any("'git.branch_naming.enabled' must be a bool" in e for e in errors)
 
 
def test_git_pre_commit_profile_invalid_rejected():
    errors = oct_lint._validate_octrc_schema(
        {"git": {"pre_commit_profile": "turbo"}}
    )
    assert any("unknown value 'turbo'" in e for e in errors)
 
 
def test_git_timeout_not_number_rejected():
    errors = oct_lint._validate_octrc_schema(
        {"git": {"timeout": "fast"}}
    )
    assert any("'git.timeout' must be a number" in e for e in errors)
 
 
def test_git_timeout_zero_rejected():
    errors = oct_lint._validate_octrc_schema(
        {"git": {"timeout": 0}}
    )
    assert any("'git.timeout' must be > 0" in e for e in errors)