test_oct_lint_schema_warning.py

Go to the documentation of this file.

#!/usr/bin/env python3
# -*- coding: utf-8 -*-
# tests/tests_linter/test_oct_lint_schema_warning.py
 
"""
Purpose
-------
OI-501 regression tests — ``.octrc.json`` schema errors must *warn* (not crash)
in non-strict mode, and *raise* ``SystemExit(2)`` only when strict-config is
enabled. Prior to the fix, ``raise SystemExit(2)`` was indented at the wrong
level, so every schema error crashed the linter unconditionally.
 
Responsibilities
----------------
- Non-strict mode + schema error → warning printed to stderr, no SystemExit(2).
- Strict mode + schema error → SystemExit(2).
- Strict mode + malformed JSON → SystemExit(2) (unchanged behaviour).
 
Diagnostics
-----------
Domain: LINTER-TESTS
Levels:
    L2 — test lifecycle
    L3 — assertion details
    L4 — deep tracing
 
Contracts
---------
- ``.octrc.json`` handling must not raise in non-strict mode.
"""
 
import io
import sys
from pathlib import Path
 
import pytest
 
from oct.linter import oct_lint
 
 
def _write_octrc(root: Path, content: str) -> None:
    (root / ".octrc.json").write_text(content, encoding="utf-8")
 
 
def test_schema_error_non_strict_warns_but_does_not_exit(
    temp_project_root: Path, monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture
):
    monkeypatch.delenv("OCT_STRICT_CONFIG", raising=False)
    # profile="bogus" → recognised schema error, not a JSON error.
    _write_octrc(temp_project_root, '{"linter": {"profile": "bogus"}}')
 
    # Must not raise SystemExit(2); linter may exit 0/1 based on lint results.
    try:
        oct_lint.run_linter(temp_project_root, argv=[])
    except SystemExit as e:
        assert e.code != 2, f"non-strict mode must not SystemExit(2); got {e.code}"
 
    err = capsys.readouterr().err
    assert "Warning" in err
    assert ".octrc.json schema errors" in err
 
 
def test_schema_error_strict_mode_exits_2(
    temp_project_root: Path, monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture
):
    monkeypatch.setenv("OCT_STRICT_CONFIG", "1")
    _write_octrc(temp_project_root, '{"linter": {"profile": "bogus"}}')
 
    with pytest.raises(SystemExit) as exc_info:
        oct_lint.run_linter(temp_project_root, argv=[])
 
    assert exc_info.value.code == 2
    err = capsys.readouterr().err
    assert "Error" in err
    assert ".octrc.json schema errors" in err
 
 
def test_malformed_json_strict_mode_exits_2(
    temp_project_root: Path, monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture
):
    monkeypatch.setenv("OCT_STRICT_CONFIG", "1")
    _write_octrc(temp_project_root, "{ not valid json")
 
    with pytest.raises(SystemExit) as exc_info:
        oct_lint.run_linter(temp_project_root, argv=[])
 
    assert exc_info.value.code == 2