test_validate_config_strict.py

Go to the documentation of this file.

#!/usr/bin/env python3
# -*- coding: utf-8 -*-
# tests/tests_diag/test_validate_config_strict.py
 
"""
Purpose
-------
OI-534 / FS-513 — ``oct diag validate-config --strict`` promotes
WARNING-level issues to failures and returns exit code 2 so CI can
distinguish a strict-mode config audit failure from the generic exit 1
used by the non-strict path (reserved for ERROR-level schema problems).
 
The tests use a temporary ``oc_diagnostics/debug_config.json`` layout so
we never touch the real project config.
 
Responsibilities
----------------
- Verify non-strict mode: ERROR exits 1, WARNING exits 0.
- Verify strict mode: both ERROR and WARNING exit 2, clean exits 0.
 
Diagnostics
-----------
Domain: DIAG-TESTS
Levels:
    L2 — test lifecycle
    L3 — assertion details
    L4 — deep tracing
 
Contracts
---------
- Non-strict: ERROR → exit 1, WARNING → exit 0.
- Strict:     ERROR → exit 2, WARNING → exit 2, clean → exit 0.
"""
 
from __future__ import annotations
 
import json
import os
from pathlib import Path
 
import pytest
from click.testing import CliRunner
 
from oct.cli import cli
 
 
def _write_config(project_root: Path, payload: dict) -> Path:
    """Drop a debug_config.json at ``<root>/oc_diagnostics/`` and return it.
 
    ``find_project_root`` anchors on ``.octrc.json`` with ``root_marker``
    set — use that rather than simulating the full ``docs/tests/...``
    layout so the fixture stays lean.
    """
    cfg_dir = project_root / "oc_diagnostics"
    cfg_dir.mkdir(parents=True, exist_ok=True)
    cfg = cfg_dir / "debug_config.json"
    cfg.write_text(json.dumps(payload, indent=2), encoding="utf-8")
    (project_root / ".octrc.json").write_text(
        json.dumps({"root_marker": True}), encoding="utf-8",
    )
    return cfg
 
 
def _invoke(cwd: Path, *args: str):
    """Run ``oct diag validate-config ...`` with cwd pinned to ``cwd``."""
    runner = CliRunner()
    prev = os.getcwd()
    try:
        os.chdir(cwd)
        return runner.invoke(cli, ["diag", "validate-config", *args])
    finally:
        os.chdir(prev)
 
 
def test_clean_config_exits_zero_in_both_modes(tmp_path: Path):
    """OI-534: a fully-valid config exits 0 regardless of --strict."""
    _write_config(tmp_path, {
        "_schema_version": "2.0",
        "DEBUG_LEVELS": {"GENERAL": {"level": 2, "color": "default"}},
        "global_settings": {"output_mode": "both", "mode": "dev"},
    })
    for args in ([], ["--strict"]):
        result = _invoke(tmp_path, *args)
        assert result.exit_code == 0, (args, result.output)
 
 
def test_warning_only_config_passes_without_strict(tmp_path: Path):
    """OI-534: WARNING issues alone exit 0 when --strict is absent."""
    # Missing _schema_version, missing global_settings → WARNINGs only.
    _write_config(tmp_path, {"domains": {"GENERAL": {"level": 2}}})
    result = _invoke(tmp_path)
    assert result.exit_code == 0, result.output
    assert "WARNING" in result.output
 
 
def test_warning_only_config_fails_with_strict(tmp_path: Path):
    """OI-534: --strict promotes WARNING to exit 2."""
    _write_config(tmp_path, {"domains": {"GENERAL": {"level": 2}}})
    result = _invoke(tmp_path, "--strict")
    assert result.exit_code == 2, result.output
    assert "WARNING" in result.output
 
 
def test_error_config_exits_one_without_strict(tmp_path: Path):
    """OI-534: non-strict ERROR → exit 1 (preserves legacy behaviour)."""
    # level=99 is out of the 0-4 range → ERROR.
    _write_config(tmp_path, {
        "_schema_version": "2.0",
        "DEBUG_LEVELS": {"GENERAL": {"level": 99, "color": "default"}},
        "global_settings": {"output_mode": "both", "mode": "dev"},
    })
    result = _invoke(tmp_path)
    assert result.exit_code == 1, result.output
    assert "ERROR" in result.output
 
 
def test_error_config_exits_two_with_strict(tmp_path: Path):
    """OI-534: --strict upgrades ERROR exit from 1 to 2."""
    _write_config(tmp_path, {
        "_schema_version": "2.0",
        "DEBUG_LEVELS": {"GENERAL": {"level": 99, "color": "default"}},
        "global_settings": {"output_mode": "both", "mode": "dev"},
    })
    result = _invoke(tmp_path, "--strict")
    assert result.exit_code == 2, result.output
    assert "ERROR" in result.output